From: Changcheng Liu <changcheng.liu@aliyun.com>
Date: Tue, 13 Oct 2020 01:47:16 +0000 (+0800)
Subject: common: remove log_early configuration option
X-Git-Tag: v14.2.22~22^2~8^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=aee91787e451c56d64af38261d687aef5577655c;p=ceph.git

common: remove log_early configuration option

After deciding to always enable tracking log in early phase, there's no
need to keep "log_early" option here and remove it directly.

Suggested-by: Kefu Chai <kefu@redhat.com>
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
(cherry picked from commit dbdcb2535d0d463d92d90169175e0776a0ee58e3)

Conflicts:
	qa/tasks/ceph_manager.py [ already dropped in nautilus, commit
	  b8dd87424ecb ("qa/tasks/ceph_manager.py: don't use log-early
	  in raw_cluster_cmd") ]
---

diff --git a/src/common/config.cc b/src/common/config.cc
index 863525efe78a0..5e19e8c06ed06 100644
--- a/src/common/config.cc
+++ b/src/common/config.cc
@@ -651,9 +651,6 @@ int md_config_t::parse_argv(ConfigValues& values,
     else if (ceph_argparse_flag(args, i, "--no-mon-config", (char*)NULL)) {
       values.no_mon_config = true;
     }
-    else if (ceph_argparse_flag(args, i, "--log-early", (char*)NULL)) {
-      values.log_early = true;
-    }
     else if (ceph_argparse_flag(args, i, "--mon-config", (char*)NULL)) {
       values.no_mon_config = false;
     }
diff --git a/src/common/config_values.h b/src/common/config_values.h
index ab52060e46292..fdfff2b16f33e 100644
--- a/src/common/config_values.h
+++ b/src/common/config_values.h
@@ -28,7 +28,6 @@ public:
   string cluster;
   ceph::logging::SubsystemMap subsys;
   bool no_mon_config = false;
-  bool log_early = false;
   // Set of configuration options that have changed since the last
   // apply_changes
   using changed_set_t = std::set<std::string>;
diff --git a/src/libcephfs.cc b/src/libcephfs.cc
index 66c066436d2e7..a48e83163fea3 100755
--- a/src/libcephfs.cc
+++ b/src/libcephfs.cc
@@ -79,8 +79,7 @@ public:
   {
     int ret;
 
-    if (cct->_conf->log_early &&
-	!cct->_log->is_started()) {
+    if (!cct->_log->is_started()) {
       cct->_log->start();
     }
 
diff --git a/src/librados/RadosClient.cc b/src/librados/RadosClient.cc
index 0ee2985ed3f28..e56ec101c4095 100644
--- a/src/librados/RadosClient.cc
+++ b/src/librados/RadosClient.cc
@@ -238,8 +238,7 @@ int librados::RadosClient::connect()
     return -EISCONN;
   state = CONNECTING;
 
-  if (cct->_conf->log_early &&
-      !cct->_log->is_started()) {
+  if (!cct->_log->is_started()) {
     cct->_log->start();
   }