From: Xuehan Xu <xuxuehan@qianxin.com>
Date: Fri, 22 Nov 2024 08:38:02 +0000 (+0800)
Subject: crimson/osd/replicated_backend: make sure the check on whether to send
X-Git-Tag: testing/wip-vshankar-testing-20250115.164543-debug~37^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=af1bc2220f6d81cfa93cbb52d6b24b2a5b93934c;p=ceph-ci.git

crimson/osd/replicated_backend: make sure the check on whether to send
ops to replica osds and the pg log append happens in the same
continuation

Since backfill relies on the pg log to discover new modifications, we
need to make sure backfill always discover the modification that's not
sent to replica osds.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
---

diff --git a/src/crimson/osd/replicated_backend.cc b/src/crimson/osd/replicated_backend.cc
index f25409b5c7b..6c8abecffaf 100644
--- a/src/crimson/osd/replicated_backend.cc
+++ b/src/crimson/osd/replicated_backend.cc
@@ -104,6 +104,8 @@ ReplicatedBackend::submit_transaction(
     }
   }
 
+  co_await pg.update_snap_map(log_entries, txn);
+
   std::vector<pg_shard_t> to_push_clone;
   std::vector<pg_shard_t> to_push_delete;
   auto sends = std::make_unique<std::vector<seastar::future<>>>();
@@ -140,8 +142,6 @@ ReplicatedBackend::submit_transaction(
 	pg_shard.osd, std::move(m), map_epoch));
   }
 
-  co_await pg.update_snap_map(log_entries, txn);
-
   pg.log_operation(
     std::move(log_entries),
     osd_op_p.pg_trim_to,