From: Kefu Chai <kchai@redhat.com>
Date: Sat, 15 Aug 2020 11:04:19 +0000 (+0800)
Subject: crimson/os: do not return a value for non-reachable branch
X-Git-Tag: v16.1.0~1421^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b168bc02b3c6349c8d824211e17309db503f873a;p=ceph.git

crimson/os: do not return a value for non-reachable branch

for silencing a warning like

btree/btree_lba_manager.cc:177:12: warning: binding dereferenced null pointer to reference has undefined behavior [-Wnull-dereference]
    return *static_cast<btree_range_pin_t*>(nullptr);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

ceph_abort_msg() is marked [[noreturn]], so we can just use it here
without worrying about complains from compiler.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc b/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc
index c90e41f058a..012b1ba61e6 100644
--- a/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc
+++ b/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc
@@ -173,8 +173,7 @@ btree_range_pin_t &BtreeLBAManager::get_pin(CachedExtent &e)
     return static_cast<BtreeLBAPin &>(
       e.cast<LogicalCachedExtent>()->get_pin()).pin;
   } else {
-    assert(0 == "impossible");
-    return *static_cast<btree_range_pin_t*>(nullptr);
+    ceph_abort_msg("impossible");
   }
 }