From: Seena Fallah <seenafallah@gmail.com>
Date: Wed, 8 Jan 2025 21:24:16 +0000 (+0100)
Subject: rgw: set retcode on verify_bucket_permission in RGWObjFetchCR
X-Git-Tag: v20.0.0~366^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=b18b5491bae83b485ab88fde33a064deba231af9;p=ceph.git

rgw: set retcode on verify_bucket_permission in RGWObjFetchCR

On destination bucket `verify_bucket_permission()` in `RGWObjFetchCR()`
use `set_cr_error()` to return `-EPERM` so it can be reflected in
`RGWBucketSyncSingleEntryCR()` for skipping on `-EPERM`.

Fixes: https://tracker.ceph.com/issues/69450
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
---

diff --git a/src/rgw/driver/rados/rgw_data_sync.cc b/src/rgw/driver/rados/rgw_data_sync.cc
index c0a9059a25179..22e08c039f328 100644
--- a/src/rgw/driver/rados/rgw_data_sync.cc
+++ b/src/rgw/driver/rados/rgw_data_sync.cc
@@ -3021,7 +3021,7 @@ public:
 
           if (!dest_bucket_perms.verify_bucket_permission(dest_key.value_or(key), rgw::IAM::s3PutObject)) {
             ldout(cct, 0) << "ERROR: " << __func__ << ": permission check failed: user not allowed to write into bucket (bucket=" << sync_pipe.info.dest_bucket.get_key() << ")" << dendl;
-            return -EPERM;
+            return set_cr_error(-EPERM);
           }
         }