From: Mayank Agarwal <amayank@fb.com>
Date: Tue, 19 Mar 2013 21:53:22 +0000 (-0700)
Subject: Fix more signed-unsigned comparisons
X-Git-Tag: v1.5.8.1~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b1bea584571f216275ce4a123a85619c7f02e89b;p=rocksdb.git

Fix more signed-unsigned comparisons

Summary: Some comparisons left in log_test.cc and db_test.cc complained by make

Test Plan: make

Reviewers: dhruba, sheki

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9537
---

diff --git a/db/db_test.cc b/db/db_test.cc
index dc069a89..a9c83a7a 100644
--- a/db/db_test.cc
+++ b/db/db_test.cc
@@ -1480,7 +1480,7 @@ TEST(DBTest, CompactionFilter) {
   while (iter->Valid()) {
     ParsedInternalKey ikey;
     ASSERT_EQ(ParseInternalKey(iter->key(), &ikey), true);
-    ASSERT_NE(ikey.sequence, 0);
+    ASSERT_NE(ikey.sequence, (unsigned)0);
     count++;
     iter->Next();
   }
diff --git a/db/log_test.cc b/db/log_test.cc
index 1840090b..367e2f18 100644
--- a/db/log_test.cc
+++ b/db/log_test.cc
@@ -450,13 +450,13 @@ TEST(LogTest, ErrorJoinsRecords) {
   Write("correct");
 
   // Wipe the middle block
-  for (int offset = kBlockSize; offset < 2*kBlockSize; offset++) {
+  for (unsigned int offset = kBlockSize; offset < 2*kBlockSize; offset++) {
     SetByte(offset, 'x');
   }
 
   ASSERT_EQ("correct", Read());
   ASSERT_EQ("EOF", Read());
-  const int dropped = DroppedBytes();
+  const unsigned int dropped = DroppedBytes();
   ASSERT_LE(dropped, 2*kBlockSize + 100);
   ASSERT_GE(dropped, 2*kBlockSize);
 }