From: Adam C. Emerson <aemerson@redhat.com>
Date: Fri, 3 Feb 2017 19:33:10 +0000 (-0500)
Subject: rgw: Classes with virtual functions get virtual destructors
X-Git-Tag: v12.0.1~478^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b24e438b40b762cd46e9e3be3c227393babc2b77;p=ceph.git

rgw: Classes with virtual functions get virtual destructors

Including template specializations.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
---

diff --git a/src/test/librbd/test_mock_ExclusiveLock.cc b/src/test/librbd/test_mock_ExclusiveLock.cc
index fc36534da77b..b05bef2a1455 100644
--- a/src/test/librbd/test_mock_ExclusiveLock.cc
+++ b/src/test/librbd/test_mock_ExclusiveLock.cc
@@ -43,6 +43,8 @@ struct ManagedLock<MockExclusiveLockImageCtx> {
     : m_lock("ManagedLock::m_lock") {
   }
 
+  virtual ~ManagedLock() = default;
+
   mutable Mutex m_lock;
 
   virtual void shutdown_handler(int r, Context *) = 0;
diff --git a/src/test/rbd_mirror/test_mock_LeaderWatcher.cc b/src/test/rbd_mirror/test_mock_LeaderWatcher.cc
index 8477fce6193c..f827e180ad9e 100644
--- a/src/test/rbd_mirror/test_mock_LeaderWatcher.cc
+++ b/src/test/rbd_mirror/test_mock_LeaderWatcher.cc
@@ -56,6 +56,8 @@ struct ManagedLock<MockTestImageCtx> {
     : m_lock("ManagedLock::m_lock") {
   }
 
+  virtual ~ManagedLock() = default;
+
   mutable Mutex m_lock;
 
   bool is_lock_owner() const {