From: David Galloway Date: Thu, 26 Mar 2026 21:51:26 +0000 (-0400) Subject: mgr/mgr_module.py: add COMMANDS class attribute to CLICommandBase X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b3b9ea3ccf7d85b402b0d4bba70dd837d58f79c7;p=ceph.git mgr/mgr_module.py: add COMMANDS class attribute to CLICommandBase CLICommandBase was missing a COMMANDS dict, causing an AttributeError when the mgr daemon tried to load the rook module. Subtypes created via make_registry_subtype get their own COMMANDS dict, but the base class needs one too as a fallback. Signed-off-by: David Galloway --- diff --git a/src/pybind/mgr/mgr_module.py b/src/pybind/mgr/mgr_module.py index 7726931da0e0..fa566fcbd60b 100644 --- a/src/pybind/mgr/mgr_module.py +++ b/src/pybind/mgr/mgr_module.py @@ -408,6 +408,8 @@ def _extract_target_func( class CLICommandBase(object): + COMMANDS: Dict[str, 'CLICommandBase'] = {} + def __init__(self, prefix: str, perm: str = 'rw',