From: Samuel Just <sjust@redhat.com>
Date: Tue, 15 Apr 2025 22:18:13 +0000 (-0700)
Subject: crimson: update PGRecovery::recover_object_with_throttle to use logging macros
X-Git-Tag: v20.3.0~42^2~2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=b3e55c48564d616ebedd3e0555627bb917b580bc;p=ceph.git

crimson: update PGRecovery::recover_object_with_throttle to use logging macros

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/osd/pg.h b/src/crimson/osd/pg.h
index 0a20f2c4d6241..110c5e79dad61 100644
--- a/src/crimson/osd/pg.h
+++ b/src/crimson/osd/pg.h
@@ -733,6 +733,9 @@ public:
   ShardServices& get_shard_services() final {
     return shard_services;
   }
+  DoutPrefixProvider& get_dpp() final {
+    return *this;
+  }
   seastar::future<> stop();
 private:
   class C_PG_FinishRecovery : public Context {
diff --git a/src/crimson/osd/pg_recovery.cc b/src/crimson/osd/pg_recovery.cc
index 2b28f7e4f0f4b..c7b41b7066351 100644
--- a/src/crimson/osd/pg_recovery.cc
+++ b/src/crimson/osd/pg_recovery.cc
@@ -5,6 +5,7 @@
 #include <fmt/ostream.h>
 #include <fmt/ranges.h>
 
+#include "crimson/common/log.h"
 #include "crimson/common/type_helpers.h"
 #include "crimson/osd/backfill_facades.h"
 #include "crimson/osd/osd_operations/background_recovery.h"
@@ -16,6 +17,8 @@
 #include "osd/osd_types.h"
 #include "osd/PeeringState.h"
 
+SET_SUBSYS(osd);
+
 namespace {
   seastar::logger& logger() {
     return crimson::get_logger(ceph_subsys_osd);
@@ -525,14 +528,15 @@ PGRecovery::recover_object_with_throttle(
   const hobject_t &soid,
   eversion_t need)
 {
+  LOG_PREFIX(PGRecovery::recover_object_with_throttle);
   crimson::osd::scheduler::params_t params =
     {1, 0, crimson::osd::scheduler::scheduler_class_t::background_best_effort};
   auto &ss = pg->get_shard_services();
-  logger().debug("{} {}", soid, need);
+  DEBUGDPP("{} {}", pg->get_dpp(), soid, need);
   return ss.with_throttle(
     std::move(params),
-    [this, soid, need] {
-    logger().debug("got throttle: {} {}", soid, need);
+    [FNAME, this, soid, need] {
+    DEBUGDPP("got throttle: {} {}", pg->get_dpp(), soid, need);
     auto backend = pg->get_recovery_backend();
     assert(backend);
     return backend->recover_object(soid, need);
diff --git a/src/crimson/osd/pg_recovery_listener.h b/src/crimson/osd/pg_recovery_listener.h
index 6c88b170b4fb9..347a3b2194e31 100644
--- a/src/crimson/osd/pg_recovery_listener.h
+++ b/src/crimson/osd/pg_recovery_listener.h
@@ -20,6 +20,7 @@ class PGRecovery;
 class PGRecoveryListener {
 public:
   virtual crimson::osd::ShardServices& get_shard_services() = 0;
+  virtual DoutPrefixProvider& get_dpp() = 0;
   virtual PGRecovery* get_recovery_handler() = 0;
   virtual epoch_t get_osdmap_epoch() const = 0;
   virtual bool is_primary() const = 0;