From: Soumya Koduri <skoduri@redhat.com>
Date: Mon, 1 Nov 2021 06:21:29 +0000 (+0530)
Subject: rgw/dbstore: No need for explicit LOCK in DBStore
X-Git-Tag: v17.1.0~527^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=b3ecfc8f8419e801e6ea51f8d8d7fd6b7740cb09;p=ceph-ci.git

rgw/dbstore: No need for explicit LOCK in DBStore

The current form of DBStore is not suited for multiple writers
scenario. Hence no need for explicit mutex lock in DBStore but
rather rely on inherent sqlite locking mechanism.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
---

diff --git a/src/rgw/store/dbstore/common/dbstore.cc b/src/rgw/store/dbstore/common/dbstore.cc
index 7cf8c44413b..c771763ff7f 100644
--- a/src/rgw/store/dbstore/common/dbstore.cc
+++ b/src/rgw/store/dbstore/common/dbstore.cc
@@ -250,17 +250,14 @@ int DB::ProcessOp(const DoutPrefixProvider *dpp, string Op, struct DBOpParams *p
   int ret = -1;
   class DBOp *db_op;
 
-  Lock(dpp);
   db_op = getDBOp(dpp, Op, params);
 
   if (!db_op) {
     ldpp_dout(dpp, 0)<<"No db_op found for Op("<<Op<<")" << dendl;
-    Unlock(dpp);
     return ret;
   }
   ret = db_op->Execute(dpp, params);
 
-  Unlock(dpp);
   if (ret) {
     ldpp_dout(dpp, 0)<<"In Process op Execute failed for fop(" \
       <<Op.c_str()<<") " << dendl;