From: Michael Fritch <mfritch@suse.com>
Date: Thu, 28 Jan 2021 18:24:57 +0000 (-0700)
Subject: mgr/cephadm: use ==/!= to compare constant literals (F632)
X-Git-Tag: v17.1.0~3027^2~7
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=b40d28ce900fc4eb88be2480ae584c095120a51a;p=ceph-ci.git

mgr/cephadm: use ==/!= to compare constant literals (F632)

Signed-off-by: Michael Fritch <mfritch@suse.com>
---

diff --git a/src/pybind/mgr/cephadm/tests/test_cephadm.py b/src/pybind/mgr/cephadm/tests/test_cephadm.py
index fe1d5336626..0603720d2a4 100644
--- a/src/pybind/mgr/cephadm/tests/test_cephadm.py
+++ b/src/pybind/mgr/cephadm/tests/test_cephadm.py
@@ -835,13 +835,13 @@ class TestCephadm(object):
                 with with_host(cephadm_module, 'test', refresh_hosts=False):
                     code, out, err = cephadm_module.check_host('test')
                     # First should succeed.
-                    assert err is ''
+                    assert err == ''
 
                     # On second it should attempt to reuse the connection, where the
                     # connection is "down" so will recreate the connection. The old
                     # code will blow up here triggering the BOOM!
                     code, out, err = cephadm_module.check_host('test')
-                    assert err is ''
+                    assert err == ''
 
     @mock.patch("cephadm.module.CephadmOrchestrator._get_connection")
     @mock.patch("remoto.process.check")
diff --git a/src/pybind/mgr/tox.ini b/src/pybind/mgr/tox.ini
index cb88ec4d0e6..5334020eb33 100644
--- a/src/pybind/mgr/tox.ini
+++ b/src/pybind/mgr/tox.ini
@@ -13,7 +13,6 @@ max-line-length = 100
 ignore =
     E501,
     F401,
-    F632,
     F811,
     F821,
     F841,