From: Afreen Misbah Date: Thu, 18 Dec 2025 21:46:05 +0000 (+0530) Subject: mgr/dashboard: Add footer X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b5620f74dd62f0e41c9be0f6ec10eec91915d239;p=ceph.git mgr/dashboard: Add footer Signed-off-by: Afreen Misbah --- diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss index f6767694ad9..bcf211a394e 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-area/notification-area.component.scss @@ -10,9 +10,8 @@ padding: $spacing-05 $spacing-05 $spacing-03; background-color: $layer-01; position: sticky; - top: 0; z-index: 2; - display: block; + inset-block-start: 3.6125rem; } .notification-timestamp { @@ -110,9 +109,3 @@ border-bottom: 1px solid $border-subtle-01; } -:host { - display: block; - height: 100%; - overflow-y: auto; - background-color: $layer-01; -} diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.html index 4d6475a55e8..3afd57c71bd 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.html @@ -2,6 +2,7 @@ View all diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.scss index 0a513f7475a..a2209232581 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.scss +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.scss @@ -2,16 +2,17 @@ @use '@carbon/styles/scss/theme'; .notification-footer { + position: sticky; + z-index: 2; display: flex; - justify-content: flex-start; - padding: spacing.$spacing-03; - border-top: 1px solid theme.$border-subtle-01; - - cds-button { + align-items: center; + background-color: theme.$layer-01; + block-size: 2.5rem; + border-block-start: 1px solid theme.$border-subtle-01; + inset-block-end: 0; + min-block-size: 2.5rem; + &__view-all-button { color: theme.$text-primary; - - &:hover { - color: theme.$link-primary; - } + padding: spacing.$spacing-03 spacing.$spacing-05; } } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.ts index 5dcf0d39c36..d62ff40fc2d 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-footer/notification-footer.component.ts @@ -14,4 +14,5 @@ export class NotificationFooterComponent { event.stopPropagation(); this.notificationService.toggleSidebar(false, true); } + } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-header/notification-header.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-header/notification-header.component.scss index d903bf860d6..87f8cb4a71f 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-header/notification-header.component.scss +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-header/notification-header.component.scss @@ -19,5 +19,4 @@ &__dismiss-btn { color: theme.$text-primary; } - } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.html index 826957a0206..f23d47b02fa 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.html @@ -4,13 +4,14 @@ cdsTheme="g10" class="notification-panel__container" hasScrollingContent="true" + (dismissAll)="handleDismissAll" @panelAnimation> - - - + + + diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.ts index 1eb245f4c84..f82a6a798a8 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notification-panel/notification-panel/notification-panel.component.ts @@ -21,6 +21,12 @@ import { trigger, transition, style, animate } from '@angular/animations'; }) export class NotificationPanelComponent { @Input() isPanelOpen: boolean = true; + showFooter = true; constructor(public notificationService: NotificationService) {} + + handleDismissAll() { + this.showFooter = false; + // TODO: Also hoide if there is afooter + } }