From: Kyr Shatskyy Date: Fri, 21 Feb 2020 21:28:56 +0000 (+0100) Subject: qa/tasks/divergent_priors2: get rid of cStringIO for py3 X-Git-Tag: v15.1.1~129^2~5 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b6eefbb02896043333f264023274e83ec36b8362;p=ceph.git qa/tasks/divergent_priors2: get rid of cStringIO for py3 Signed-off-by: Kyr Shatskyy --- diff --git a/qa/tasks/divergent_priors2.py b/qa/tasks/divergent_priors2.py index 12a9fd4a9afc..dda358b045fd 100644 --- a/qa/tasks/divergent_priors2.py +++ b/qa/tasks/divergent_priors2.py @@ -3,8 +3,8 @@ Special case divergence test with ceph-objectstore-tool export/remove/import """ import logging import time -from cStringIO import StringIO +from teuthology.exceptions import CommandFailedError from teuthology import misc as teuthology from util.rados import rados import os @@ -158,15 +158,17 @@ def task(ctx, config): expfile = os.path.join(testdir, "exp.{pid}.out".format(pid=pid)) cmd = ((prefix + "--op export-remove --pgid 2.0 --file {file}"). format(id=divergent, file=expfile)) - proc = exp_remote.run(args=cmd, wait=True, - check_status=False, stdout=StringIO()) - assert proc.exitstatus == 0 + try: + exp_remote.sh(cmd, wait=True) + except CommandFailedError as e: + assert e.exitstatus == 0 cmd = ((prefix + "--op import --file {file}"). format(id=divergent, file=expfile)) - proc = exp_remote.run(args=cmd, wait=True, - check_status=False, stdout=StringIO()) - assert proc.exitstatus == 0 + try: + exp_remote.sh(cmd, wait=True) + except CommandFailedError as e: + assert e.exitstatus == 0 log.info("reviving divergent %d", divergent) manager.revive_osd(divergent)