From: Ramana Raja <rraja@redhat.com>
Date: Fri, 29 Jul 2022 21:51:14 +0000 (-0400)
Subject: mds/Locker: remove session check access when doing cap updates
X-Git-Tag: testing/wip-pdonnell-testing-20240430.123648-reef-debug~91^2~10
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=b72508438e1fb799c010c86e3390c626509f0dc5;p=ceph-ci.git

mds/Locker: remove session check access when doing cap updates

as it's too late. Session access authorization already happens
before new caps are issued.

Fixes: https://tracker.ceph.com/issues/56067
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 96305b5eef06e2b379ed95a086edf9e4809a7e70)
---

diff --git a/src/mds/Locker.cc b/src/mds/Locker.cc
index 3406b0e0171..d156155b5f8 100644
--- a/src/mds/Locker.cc
+++ b/src/mds/Locker.cc
@@ -3920,13 +3920,6 @@ bool Locker::_do_cap_update(CInode *in, Capability *cap,
   if (!dirty && !change_max)
     return false;
 
-  Session *session = mds->get_session(m);
-  if (session->check_access(in, MAY_WRITE,
-			    m->caller_uid, m->caller_gid, NULL, 0, 0) < 0) {
-    dout(10) << "check_access failed, dropping cap update on " << *in << dendl;
-    return false;
-  }
-
   // do the update.
   EUpdate *le = new EUpdate(mds->mdlog, "cap update");
   mds->mdlog->start_entry(le);