From: Willem Jan Withagen Date: Wed, 27 Jul 2016 16:18:55 +0000 (+0200) Subject: src/kv/MemDB.cc: the type of the parameter of push_back() does not match the ops... X-Git-Tag: ses5-milestone5~168^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b7c307547965fa2ce42f91287fa362cf2d9034c2;p=ceph.git src/kv/MemDB.cc: the type of the parameter of push_back() does not match the ops's value_type - NULL is a C-type usage, which is allow by GCC. But Clang is more strict in checking. Error looks like: src/kv/MemDB.cc:228: error: no matching member function for call to 'push_back' ops.push_back(make_pair(DELETE, ~~~~^~~~~~~~~ /usr/include/c++/v1/vector:685:36: note: candidate function not viable: no known conversion from 'pair<[...], pair<[...], nullptr_t>>' to 'const pair<[...], pair<[...], ceph::buffer::list>>' for 1st argument _LIBCPP_INLINE_VISIBILITY void push_back(const_reference __x); ^ Signed-off-by: Willem Jan Withagen --- diff --git a/src/kv/MemDB.cc b/src/kv/MemDB.cc index 49205e40a278..b7d1a253dc6a 100644 --- a/src/kv/MemDB.cc +++ b/src/kv/MemDB.cc @@ -227,7 +227,7 @@ void MemDB::MDBTransactionImpl::rmkey(const string &prefix, dtrace << __func__ << " " << prefix << " " << k << dendl; ops.push_back(make_pair(DELETE, std::make_pair(std::make_pair(prefix, k), - NULL))); + bufferlist()))); } void MemDB::MDBTransactionImpl::rmkeys_by_prefix(const string &prefix)