From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Tue, 24 Feb 2015 08:21:17 +0000 (+0100)
Subject: libradosstriper/striping.cc: fix resource leak
X-Git-Tag: suse_latest~18^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b7ea69265dd945ff08a829c3f9918ea0190b148a;p=ceph.git

libradosstriper/striping.cc: fix resource leak

Fix for:

CID 1221525 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Failing to save or free storage allocated
 by this->getObjName(soid, 0UL) leaks it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/libradosstriper/striping.cc b/src/test/libradosstriper/striping.cc
index 9b26329c6fcc..404256637f7e 100644
--- a/src/test/libradosstriper/striping.cc
+++ b/src/test/libradosstriper/striping.cc
@@ -230,7 +230,7 @@ TEST_P(StriperTestRT, StripedRoundtrip) {
     // recreate object
     ASSERT_EQ(0, striper.write(soid, bl1, testData.size*2, 0));
     // remove the object size attribute from the striped object
-    std::string firstOid = getObjName(soid, 0);
+    char* firstOid = getObjName(soid, 0);
     ASSERT_EQ(0, ioctx.rmxattr(firstOid, "striper.size"));
     // check that stat fails
     uint64_t size;
@@ -244,6 +244,7 @@ TEST_P(StriperTestRT, StripedRoundtrip) {
          object_nb++) {
       ASSERT_EQ(-ENOENT, ioctx.stat(getObjName(soid, object_nb), &size, &mtime));
     }
+    free(firstOid);
   }
 }