From: Laura Flores <lflores@redhat.com>
Date: Tue, 10 Aug 2021 21:55:45 +0000 (+0000)
Subject: mgr/telemetry: fix issue with incompatible types
X-Git-Tag: v17.1.0~1008^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b875c9b5ac621dc2e3563f56c1bd067a305bba7c;p=ceph.git

mgr/telemetry: fix issue with incompatible types

Signed-off-by: Laura Flores <lflores@redhat.com>
---

diff --git a/src/pybind/mgr/telemetry/module.py b/src/pybind/mgr/telemetry/module.py
index 4d6433e8c41c..91596436a9d8 100644
--- a/src/pybind/mgr/telemetry/module.py
+++ b/src/pybind/mgr/telemetry/module.py
@@ -354,7 +354,7 @@ class Module(MgrModule):
 
         return result
 
-    def get_osd_histograms(self) -> Dict[str, dict]:
+    def get_osd_histograms(self) -> List[Dict[str, dict]]:
         # Initialize result dict
         result: Dict[str, dict] = defaultdict(lambda: defaultdict(
                                               lambda: defaultdict(
@@ -455,7 +455,7 @@ class Module(MgrModule):
                 # by returning an empty dict.
                 except (json.decoder.JSONDecodeError, KeyError) as e:
                     self.log.debug("Error caught: {}".format(e))
-                    return {}
+                    return list()
 
         return list(result.values())