From: Christoph Hellwig <hch@lst.de>
Date: Fri, 28 Nov 2025 06:29:41 +0000 (+0100)
Subject: logprint: cleanup xlog_print_op_header
X-Git-Tag: v6.18.0~68
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b8f52c536a3b5907078e18b54713342f02adcd7c;p=xfsprogs-dev.git

logprint: cleanup xlog_print_op_header

Re-indent and drop typedef use.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
---

diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 505b6f0f..5d44c2b1 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -98,44 +98,45 @@ print_or_dump(char *ptr, int len)
  * a log operation header.
  */
 void
-xlog_print_op_header(xlog_op_header_t	*op_head,
-		     int		i,
-		     char		**ptr)
+xlog_print_op_header(
+	struct xlog_op_header	*ophdr,
+	int			i,
+	char			**ptr)
 {
-    xlog_op_header_t hbuf;
-
-    /*
-     * memmove because on 64/n32, partial reads can cause the op_head
-     * pointer to come in pointing to an odd-numbered byte
-     */
-    memmove(&hbuf, op_head, sizeof(xlog_op_header_t));
-    op_head = &hbuf;
-    *ptr += sizeof(xlog_op_header_t);
-    printf(_("Oper (%d): tid: %x  len: %d  clientid: %s  "), i,
-	    be32_to_cpu(op_head->oh_tid),
-	    be32_to_cpu(op_head->oh_len),
-	    (op_head->oh_clientid == XFS_TRANSACTION ? "TRANS" :
-	    (op_head->oh_clientid == XFS_LOG ? "LOG" : "ERROR")));
-    printf(_("flags: "));
-    if (op_head->oh_flags) {
-	if (op_head->oh_flags & XLOG_START_TRANS)
-	    printf("START ");
-	if (op_head->oh_flags & XLOG_COMMIT_TRANS)
-	    printf("COMMIT ");
-	if (op_head->oh_flags & XLOG_WAS_CONT_TRANS)
-	    printf("WAS_CONT ");
-	if (op_head->oh_flags & XLOG_UNMOUNT_TRANS)
-	    printf("UNMOUNT ");
-	if (op_head->oh_flags & XLOG_CONTINUE_TRANS)
-	    printf("CONTINUE ");
-	if (op_head->oh_flags & XLOG_END_TRANS)
-	    printf("END ");
-    } else {
-	printf(_("none"));
-    }
-    printf("\n");
-}	/* xlog_print_op_header */
-
+	struct xlog_op_header	hbuf;
+
+	/*
+	 * memmove because on 64/n32, partial reads can cause the op_head
+	 * pointer to come in pointing to an odd-numbered byte
+	 */
+	memmove(&hbuf, ophdr, sizeof(hbuf));
+	ophdr = &hbuf;
+	*ptr += sizeof(hbuf);
+
+	printf(_("Oper (%d): tid: %x  len: %d  clientid: %s  "), i,
+		be32_to_cpu(ophdr->oh_tid),
+		be32_to_cpu(ophdr->oh_len),
+		(ophdr->oh_clientid == XFS_TRANSACTION ? "TRANS" :
+		(ophdr->oh_clientid == XFS_LOG ? "LOG" : "ERROR")));
+	printf(_("flags: "));
+	if (ophdr->oh_flags) {
+		if (ophdr->oh_flags & XLOG_START_TRANS)
+			printf("START ");
+		if (ophdr->oh_flags & XLOG_COMMIT_TRANS)
+			printf("COMMIT ");
+		if (ophdr->oh_flags & XLOG_WAS_CONT_TRANS)
+			printf("WAS_CONT ");
+		if (ophdr->oh_flags & XLOG_UNMOUNT_TRANS)
+			printf("UNMOUNT ");
+		if (ophdr->oh_flags & XLOG_CONTINUE_TRANS)
+			printf("CONTINUE ");
+		if (ophdr->oh_flags & XLOG_END_TRANS)
+			printf("END ");
+	} else {
+		printf(_("none"));
+	}
+	printf("\n");
+}
 
 static void
 xlog_print_add_to_trans(xlog_tid_t	tid,