From: Travis Rhoden <trhoden@redhat.com>
Date: Wed, 1 Jul 2015 18:55:17 +0000 (-0700)
Subject: [RM-12150] Require at least one host for 'mds create'
X-Git-Tag: v1.5.26~12^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=b9b0459c46eaf4e4566dde4a1f902c8a8031ad09;p=ceph-deploy.git

[RM-12150] Require at least one host for 'mds create'

Signed-off-by: Travis Rhoden <trhoden@redhat.com>
---

diff --git a/ceph_deploy/mds.py b/ceph_deploy/mds.py
index 4304419..d053aca 100644
--- a/ceph_deploy/mds.py
+++ b/ceph_deploy/mds.py
@@ -131,9 +131,6 @@ def mds_create(args):
         ' '.join(':'.join(x or '' for x in t) for t in args.mds),
         )
 
-    if not args.mds:
-        raise exc.NeedHostError()
-
     key = get_bootstrap_mds_key(cluster=args.cluster)
 
     bootstrapped = set()
@@ -220,7 +217,7 @@ def make(parser):
     mds_create.add_argument(
         'mds',
         metavar='HOST[:NAME]',
-        nargs='*',
+        nargs='+',
         type=colon_separated,
         help='host (and optionally the daemon name) to deploy on',
         )
diff --git a/ceph_deploy/tests/parser/test_mds.py b/ceph_deploy/tests/parser/test_mds.py
index 5f68d84..ec9a02b 100644
--- a/ceph_deploy/tests/parser/test_mds.py
+++ b/ceph_deploy/tests/parser/test_mds.py
@@ -16,7 +16,6 @@ class TestParserMDS(object):
         assert 'positional arguments:' in out
         assert 'optional arguments:' in out
 
-    @pytest.mark.skipif(reason="http://tracker.ceph.com/issues/12150")
     def test_mds_create_host_required(self, capsys):
         with pytest.raises(SystemExit):
             self.parser.parse_args('mds create'.split())