From: Samuel Just <sjust@redhat.com>
Date: Thu, 18 Mar 2021 05:44:12 +0000 (-0700)
Subject: crimson/os/seastore/cache: root may not be loaded in duplicate_for_write
X-Git-Tag: v17.1.0~2478^2~19
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ba42769986c9ab896a5a228adb415d14ddea67af;p=ceph.git

crimson/os/seastore/cache: root may not be loaded in duplicate_for_write

In particular, SegmentCleaner::rewite_dirty may operate on root as the
first operation.

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/os/seastore/cache.cc b/src/crimson/os/seastore/cache.cc
index 57d5bf5406ea..e976d9bb6604 100644
--- a/src/crimson/os/seastore/cache.cc
+++ b/src/crimson/os/seastore/cache.cc
@@ -177,8 +177,6 @@ CachedExtentRef Cache::duplicate_for_write(
   ret->prior_instance = i;
   t.add_mutated_extent(ret);
   if (ret->get_type() == extent_types_t::ROOT) {
-    // root must be loaded before mutate
-    assert(t.root == i);
     t.root = ret->cast<RootBlock>();
   } else {
     ret->last_committed_crc = i->last_committed_crc;