From: Michael Fritch <mfritch@suse.com>
Date: Tue, 26 Jan 2021 19:02:38 +0000 (-0700)
Subject: mgr/cephadm: introduce flake8
X-Git-Tag: v17.1.0~3027^2~28
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=baacb36be008d61cc21bb0f94a005e2d6a510866;p=ceph.git

mgr/cephadm: introduce flake8

Signed-off-by: Michael Fritch <mfritch@suse.com>
---

diff --git a/src/pybind/mgr/CMakeLists.txt b/src/pybind/mgr/CMakeLists.txt
index 6ea957b3925b..679d0d9ae58b 100644
--- a/src/pybind/mgr/CMakeLists.txt
+++ b/src/pybind/mgr/CMakeLists.txt
@@ -6,7 +6,7 @@ if(WITH_MGR_ROOK_CLIENT)
 endif()
 if(WITH_TESTS)
   include(AddCephTest)
-  add_tox_test(mgr ${CMAKE_CURRENT_SOURCE_DIR} TOX_ENVS py3 mypy)
+  add_tox_test(mgr ${CMAKE_CURRENT_SOURCE_DIR} TOX_ENVS py3 mypy flake8)
 endif()
 
 # Location needs to match default setting for mgr_module_path, currently:
diff --git a/src/pybind/mgr/tox.ini b/src/pybind/mgr/tox.ini
index 15e1b502fb89..d9597be5d9c2 100644
--- a/src/pybind/mgr/tox.ini
+++ b/src/pybind/mgr/tox.ini
@@ -4,11 +4,43 @@ envlist =
     mypy,
     test,
     fix
+    flake8
 skipsdist = true
 requires = cython
 
 [flake8]
 max-line-length = 100
+ignore =
+    E114,
+    E121,
+    E122,
+    E124,
+    E126,
+    E128,
+    E131,
+    E225,
+    E226,
+    E231,
+    E241,
+    E261,
+    E302,
+    E306,
+    E501,
+    E703,
+    E704,
+    E712,
+    E722,
+    E731,
+    E741,
+    F401,
+    F541,
+    F632,
+    F811,
+    F821,
+    F841,
+    W291,
+    W503,
+    W504,
 exclude =
     .tox,
     .vagrant,
@@ -16,6 +48,7 @@ exclude =
     *.pyc,
     templates,
     .eggs
+statistics = True
 
 [autopep8]
 addopts =
@@ -101,3 +134,14 @@ commands =
     python --version
     autopep8 {[autopep8]addopts} \
       {posargs:{[testenv:fix]modules}}
+
+[testenv:flake8]
+basepython = python3
+deps =
+    flake8
+modules =
+    cephadm
+    orchestrator
+commands =
+    flake8 --config=tox.ini {posargs} \
+      {posargs:{[testenv:flake8]modules}}