From: Kefu Chai Date: Sat, 23 May 2020 03:29:51 +0000 (+0800) Subject: qa/tasks/mds_thrash: s/random.sample/random.choice/ X-Git-Tag: v16.1.0~2174^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=bb2c587435a5416e7c3970d822f32fb8f9dd0aaf;p=ceph.git qa/tasks/mds_thrash: s/random.sample/random.choice/ * use list comprehension instead of concatenating two ranges for better readablity -- we want to skip current max_mds for changing it. this helps reader to understand the goal of thrashing * random.sample() is replaced with random.choice(). the latter is a better alternative, if the number of samples is 1. Signed-off-by: Kefu Chai --- diff --git a/qa/tasks/mds_thrash.py b/qa/tasks/mds_thrash.py index 11e647b8a05f..ebd9e81a30ab 100644 --- a/qa/tasks/mds_thrash.py +++ b/qa/tasks/mds_thrash.py @@ -246,10 +246,9 @@ class MDSThrasher(Thrasher, Greenlet): if random.random() <= self.thrash_max_mds: max_mds = status.get_fsmap(self.fs.id)['mdsmap']['max_mds'] - options = list(range(1, max_mds))+list(range(max_mds+1, self.max_mds+1)) + options = [i for i in range(1, self.max_mds + 1) if i != max_mds] if len(options) > 0: - sample = random.sample(options, 1) - new_max_mds = sample[0] + new_max_mds = random.choice(options) self.log('thrashing max_mds: %d -> %d' % (max_mds, new_max_mds)) self.fs.set_max_mds(new_max_mds) stats['max_mds'] += 1