From: Neha Ojha <nojha@redhat.com>
Date: Thu, 15 Apr 2021 16:44:27 +0000 (+0000)
Subject: common/options/global.yaml.in: increase default value of bluestore_cache_trim_max_ski... 
X-Git-Tag: v15.2.13~17^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=be748582c375c3faf4b61fca7a371475a4096c12;p=ceph.git

common/options/global.yaml.in: increase default value of bluestore_cache_trim_max_skip_pinned

This option controls the rate of trimming of onodes and the earlier default of
64 has been seen to be too low for large clusters, leading to buildup of
onodes resulting in memory growth.

Increase the default value to 1000, since there are no known downsides to it.

Fixes: https://tracker.ceph.com/issues/50217
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 26d7336d6b65f987298ede5d2c5c435191f1405c)

 Conflicts:
	src/common/options/global.yaml.in - file does not exist in octopus
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 4ce2689c234..a6c24798ad0 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4385,7 +4385,7 @@ std::vector<Option> get_global_options() {
     .set_description("How frequently we trim the bluestore cache"),
 
     Option("bluestore_cache_trim_max_skip_pinned", Option::TYPE_UINT, Option::LEVEL_DEV)
-    .set_default(64)
+    .set_default(1000)
     .set_description("Max pinned cache entries we consider before giving up"),
 
     Option("bluestore_cache_type", Option::TYPE_STR, Option::LEVEL_DEV)