From: Matan Breizman <mbreizma@redhat.com>
Date: Thu, 10 Apr 2025 13:12:36 +0000 (+0000)
Subject: crimson/common/errorator: add TODO
X-Git-Tag: v20.3.0~28^2~11
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=be9d9044652d3d1913982809697fc9d6da8df861;p=ceph.git

crimson/common/errorator: add TODO

There are few TODOs around errorator code which might be worth looking
into: https://tracker.ceph.com/issues/70875

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/crimson/common/errorator.h b/src/crimson/common/errorator.h
index b13afd8334076..75bce8d663d6b 100644
--- a/src/crimson/common/errorator.h
+++ b/src/crimson/common/errorator.h
@@ -409,6 +409,8 @@ public:
       // However, this shouldn't be a big issue for `errorator` as
       // ErrorVisitorT are already checked for exhaustiveness at compile-time.
       if (type_info == ErrorT::error_t::get_exception_ptr_type_info()) {
+
+        // TODO: add missing explanation
         if constexpr (std::is_assignable_v<decltype(result), return_t>) {
           result = std::invoke(std::forward<ErrorVisitorT>(errfunc),
                                ErrorT::error_t::from_exception_ptr(std::move(ep)));