From: Patrick Donnelly <pdonnell@redhat.com>
Date: Wed, 27 Sep 2017 16:29:39 +0000 (-0700)
Subject: mds: fix conf types
X-Git-Tag: v13.0.1~744^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=bfc490249566356cff785f2f89dc03d69af322da;p=ceph.git

mds: fix conf types

This correct an assertion failure.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index e8fb47a3396..1d67d286f54 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -5782,7 +5782,7 @@ std::vector<Option> get_mds_options() {
     .set_default(1024)
     .set_description(""),
  
-    Option("mds_min_caps_per_client", Option::TYPE_INT, Option::LEVEL_ADVANCED)
+    Option("mds_min_caps_per_client", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
     .set_default(100)
     .set_description("Set the minimum cache number of client"),
 
diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 54495e1c33f..3c339210fc9 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -1083,8 +1083,8 @@ void Server::recover_filelocks(CInode *in, bufferlist locks, int64_t client)
 void Server::recall_client_state(void)
 {
   /* try to recall at least 80% of all caps */
-  uint64_t max_caps_per_client = (uint64_t)(Capability::count() * g_conf->get_val<float>("mds_max_ratio_caps_per_client"));
-  uint64_t min_caps_per_client = (uint64_t)g_conf->get_val<int>("mds_min_caps_per_client");
+  uint64_t max_caps_per_client = Capability::count() * g_conf->get_val<double>("mds_max_ratio_caps_per_client");
+  uint64_t min_caps_per_client = g_conf->get_val<uint64_t>("mds_min_caps_per_client");
   if (max_caps_per_client < min_caps_per_client) {
     dout(0) << "max_caps_per_client " << max_caps_per_client
             << "<" << "min_caps_per_client " << min_caps_per_client << dendl;