From: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Date: Thu, 18 May 2023 12:16:10 +0000 (+0200)
Subject: mgr/dashboard: remove title tooltip of cards landing page
X-Git-Tag: v17.2.7~346^2~23
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c0b4043bc4a3c4a1e42af860c96c20ebcf30c43b;p=ceph.git

mgr/dashboard: remove title tooltip of cards landing page

Fixes: https://tracker.ceph.com/issues/61250
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit ac73126362f3ea0f26ae32218b86ad9f9ab73670)
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html
index 35dffd46c047..a2f5b9d3d240 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html
@@ -1,6 +1,6 @@
 <div class="card shadow-sm flex-fill">
   <h4 class="card-title mt-4 ms-4 mb-0">
-    {{ title }}
+    {{ cardTitle }}
   </h4>
   <div class="card-body ps-0 pe-0">
     <ng-content></ng-content>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts
index fdc34fdf7b22..287e1cfe08f0 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts
@@ -24,7 +24,7 @@ describe('CardComponent', () => {
 
   it('Setting cards title makes title visible', () => {
     const title = 'Card Title';
-    component.title = title;
+    component.cardTitle = title;
     fixture.detectChanges();
     const titleDiv = fixture.debugElement.nativeElement.querySelector('.card-title');
 
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts
index b6bb99c66909..8e93cc8645c8 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts
@@ -7,5 +7,5 @@ import { Component, Input } from '@angular/core';
 })
 export class CardComponent {
   @Input()
-  title: string;
+  cardTitle: string;
 }
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
index d8181d7a01e6..88edeb9ee15e 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
@@ -1,7 +1,7 @@
 <div class="container-fluid"
      *ngIf="healthData && enabledFeature$ | async as enabledFeature">
   <div class="row mx-0">
-    <cd-card title="Details"
+    <cd-card cardTitle="Details"
              i18n-title
              class="col-sm-3 px-3"
              [ngClass]="{'d-flex': flexHeight}">
@@ -15,7 +15,7 @@
       </dl>
     </cd-card>
 
-    <cd-card title="Status"
+    <cd-card cardTitle="Status"
              i18n-title
              class="col-sm-6 px-3 d-flex">
       <div class="d-flex ms-4 me-4 mb-5 center-content">
@@ -75,7 +75,7 @@
       </section>
     </cd-card>
 
-    <cd-card title="Capacity"
+    <cd-card cardTitle="Capacity"
              i18n-title
              class="col-sm-3 px-3"
              [ngClass]="{'d-flex': flexHeight}">
@@ -91,7 +91,7 @@
   <!-- Second row -->
   <div class="row mx-0">
     <!-- Inventory Card -->
-    <cd-card title="Inventory"
+    <cd-card cardTitle="Inventory"
              i18n-title
              class="col-sm-3 px-3 d-flex">
       <hr>
@@ -179,7 +179,7 @@
       </li>
     </cd-card>
 
-    <cd-card title="Cluster utilization"
+    <cd-card cardTitle="Cluster utilization"
              i18n-title
              class="col-sm-9 px-3 d-flex">
       <div class="ms-4 me-4 mt-0">
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts
index 677ca35905b7..2ca65a468aa6 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts
@@ -225,7 +225,7 @@ describe('Dashbord Component', () => {
 
     getHealthSpy.and.returnValue(of(payload));
     fixture.detectChanges();
-    const clusterStatusCard = fixture.debugElement.query(By.css('cd-card[title="Status"] i'));
+    const clusterStatusCard = fixture.debugElement.query(By.css('cd-card[cardTitle="Status"] i'));
     expect(clusterStatusCard.nativeElement.title).toEqual(`${payload.health.status}`);
 
     // HEALTH_ERR