From: Adam C. Emerson <aemerson@redhat.com>
Date: Tue, 24 Mar 2026 19:04:56 +0000 (-0400)
Subject: rgw/common: Remove VLA from `append_rand_alpha`
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c0c300eaeb26c372e3aac0543a901324164b9120;p=ceph.git

rgw/common: Remove VLA from `append_rand_alpha`

This is not a good function and it should be revisisted later.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
---

diff --git a/src/rgw/rgw_common.h b/src/rgw/rgw_common.h
index 3131e1d8f1dc..ff8549b98923 100644
--- a/src/rgw/rgw_common.h
+++ b/src/rgw/rgw_common.h
@@ -1644,13 +1644,14 @@ static inline int rgw_str_to_bool(const char *s, int def_val)
           strcasecmp(s, "1") == 0);
 }
 
-static inline void append_rand_alpha(CephContext *cct, const std::string& src, std::string& dest, int len)
+inline void
+append_rand_alpha(
+    CephContext* cct,
+    const std::string& src,
+    std::string& dest,
+    int len)
 {
-  dest = src;
-  char buf[len + 1];
-  gen_rand_alphanumeric(cct, buf, len);
-  dest.append("_");
-  dest.append(buf);
+  dest = fmt::format("{}_{}", src, gen_rand_alphanumeric(cct, len));
 }
 
 static inline uint64_t rgw_rounded_kb(uint64_t bytes)