From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Wed, 29 May 2013 13:24:39 +0000 (+0200)
Subject: mds/MDCache.cc: fix dereference null return value
X-Git-Tag: v0.65~168^2~6
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c0e3d04bb83361017c2f766d013161aa659264e8;p=ceph.git

mds/MDCache.cc: fix dereference null return value

Add assert to fix:

CID 716994 (#1 of 1): Dereference null return value (NULL_RETURNS)
  dereference: Dereferencing a pointer that might be null "dir" when
  calling "CDir::mark_dirty(version_t, LogSegment *)".

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc
index 330e69507d96..8c17172e5c48 100644
--- a/src/mds/MDCache.cc
+++ b/src/mds/MDCache.cc
@@ -496,6 +496,7 @@ void MDCache::_create_system_file_finish(Mutation *mut, CDentry *dn, version_t d
   CDir *dir = 0;
   if (in->inode.is_dir()) {
     dir = in->get_dirfrag(frag_t());
+    assert(dir);
     dir->mark_dirty(1, mut->ls);
     dir->mark_new(mut->ls);
   }