From: Matan Breizman <mbreizma@redhat.com>
Date: Thu, 4 Sep 2025 12:36:59 +0000 (+0000)
Subject: common/options/crimson.yaml.in: add hot_tier_generations minimum
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c163fc020e3da3db3e3c1f1026e8efd07a49c247;p=ceph.git

common/options/crimson.yaml.in: add hot_tier_generations minimum

See ExtentPlacementManager::init

dynamic_max_rewrite_generation = hot_tier_generations - 1;
ceph_assert(dynamic_max_rewrite_generation > MIN_REWRITE_GENERATION);

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/common/options/crimson.yaml.in b/src/common/options/crimson.yaml.in
index f2df2025296b..031113ae7f55 100644
--- a/src/common/options/crimson.yaml.in
+++ b/src/common/options/crimson.yaml.in
@@ -231,6 +231,7 @@ options:
   level: advanced
   desc: The number of generations in the hot tier or the whole SeaStore instance if there's only one tier.
   default: 5
+  min: 5
 - name: seastore_cold_tier_generations
   type: uint
   level: advanced
diff --git a/src/crimson/os/seastore/extent_placement_manager.cc b/src/crimson/os/seastore/extent_placement_manager.cc
index b792ca86d9f3..466c82d20dbb 100644
--- a/src/crimson/os/seastore/extent_placement_manager.cc
+++ b/src/crimson/os/seastore/extent_placement_manager.cc
@@ -203,7 +203,6 @@ void ExtentPlacementManager::init(
         "hot_tier_generations{} , cold_tier_generations {}",
         dynamic_max_rewrite_generation, hot_tier_generations,
         cold_tier_generations);
-  // TODO: hot_tier_generations should have a minumum..
   ceph_assert(dynamic_max_rewrite_generation > MIN_REWRITE_GENERATION);
 
   if (trimmer->get_backend_type() == backend_type_t::SEGMENTED) {