From: Anoop C S Date: Mon, 8 Jan 2024 11:45:26 +0000 (+0530) Subject: client: Fix parsing of xattr namespace in removexattr X-Git-Tag: testing/wip-pdonnell-testing-20240430.123648-reef-debug~65^2~1 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=c169af668dd8c5050c5e97e5864cf20ba4f3c39d;p=ceph-ci.git client: Fix parsing of xattr namespace in removexattr To match the kernel ceph client, as mentioned by the inline comments, remove the comparison with "system." xattr namespace in removexattr() code path. This is in preparation to handle the case where POSIX ACL xattrs are treated differently by kernel during removexattr operation. ref: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ceph/xattr.c#n21 Signed-off-by: Anoop C S (cherry picked from commit 655aedf605e8b5bc99976499ae5bdb8d11aa4a93) --- diff --git a/src/client/Client.cc b/src/client/Client.cc index 42ca406f84c..2e099f26e68 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -13310,7 +13310,6 @@ int Client::_removexattr(Inode *in, const char *name, const UserPerm& perms) // same xattrs supported by kernel client if (strncmp(name, "user.", 5) && - strncmp(name, "system.", 7) && strncmp(name, "security.", 9) && strncmp(name, "trusted.", 8) && strncmp(name, "ceph.", 5))