From: Sage Weil <sage@redhat.com>
Date: Thu, 8 Feb 2018 15:29:30 +0000 (-0600)
Subject: osd/PG: remove last_updated_applied, op_applied()
X-Git-Tag: v13.0.2~222^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c1c495f09754986772c28c9cc7414609572a385c;p=ceph.git

osd/PG: remove last_updated_applied, op_applied()

No longer used or needed, yay!

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/osd/PG.cc b/src/osd/PG.cc
index 16c7d1b52ad..b3878004676 100644
--- a/src/osd/PG.cc
+++ b/src/osd/PG.cc
@@ -1615,7 +1615,6 @@ void PG::activate(ObjectStore::Transaction& t,
     last_update_ondisk = info.last_update;
     min_last_complete_ondisk = eversion_t(0,0);  // we don't know (yet)!
   }
-  last_update_applied = info.last_update;
   last_rollback_info_trimmed_to_applied = pg_log.get_can_rollback_to();
 
   need_up_thru = false;
@@ -4355,8 +4354,7 @@ void PG::repair_object(
 
 /* replica_scrub
  *
- * Wait for last_update_applied to match msg->scrub_to as above. Wait
- * for pushes to complete in case of recent recovery. Build a single
+ * Wait for pushes to complete in case of recent recovery. Build a single
  * scrubmap of objects that are in the range [msg->start, msg->end).
  */
 void PG::replica_scrub(
diff --git a/src/osd/PG.h b/src/osd/PG.h
index 8a664c9607e..ee3df4a958f 100644
--- a/src/osd/PG.h
+++ b/src/osd/PG.h
@@ -827,7 +827,6 @@ protected:
 protected:
   eversion_t  last_update_ondisk;    // last_update that has committed; ONLY DEFINED WHEN is_active()
   eversion_t  last_complete_ondisk;  // last_complete that has committed.
-  eversion_t  last_update_applied;
 
   // entries <= last_rollback_info_trimmed_to_applied have been trimmed
   eversion_t  last_rollback_info_trimmed_to_applied;
diff --git a/src/osd/PrimaryLogPG.cc b/src/osd/PrimaryLogPG.cc
index dccd8cc164f..4af256c6dc5 100644
--- a/src/osd/PrimaryLogPG.cc
+++ b/src/osd/PrimaryLogPG.cc
@@ -9913,13 +9913,6 @@ void PrimaryLogPG::repop_all_committed(RepGather *repop)
   }
 }
 
-void PrimaryLogPG::op_applied(const eversion_t &applied_version)
-{
-  dout(10) << "op_applied version " << applied_version << dendl;
-  assert(applied_version == info.last_update);
-  last_update_applied = applied_version;
-}
-
 void PrimaryLogPG::eval_repop(RepGather *repop)
 {
   const MOSDOp *m = NULL;
@@ -10026,7 +10019,6 @@ void PrimaryLogPG::issue_repop(RepGather *repop, OpContext *ctx)
     repop->rep_tid,
     ctx->reqid,
     ctx->op);
-  op_applied(ctx->at_version);
 }
 
 PrimaryLogPG::RepGather *PrimaryLogPG::new_repop(
@@ -10221,7 +10213,6 @@ void PrimaryLogPG::submit_log_entries(
 	new OnComplete{this, rep_tid, get_osdmap()->get_epoch()});
       int r = osd->store->queue_transaction(ch, std::move(t), NULL);
       assert(r == 0);
-      op_applied(info.last_update);
     });
 }
 
@@ -11197,7 +11188,6 @@ void PrimaryLogPG::do_update_log_missing(OpRequestRef &op)
     std::move(t),
     nullptr);
   assert(tr == 0);
-  op_applied(info.last_update);
 }
 
 void PrimaryLogPG::do_update_log_missing_reply(OpRequestRef &op)
diff --git a/src/osd/PrimaryLogPG.h b/src/osd/PrimaryLogPG.h
index 0cdbc3a40a2..900a88a2e46 100644
--- a/src/osd/PrimaryLogPG.h
+++ b/src/osd/PrimaryLogPG.h
@@ -414,8 +414,6 @@ public:
     append_log(logv, trim_to, roll_forward_to, t, transaction_applied);
   }
 
-  void op_applied(const eversion_t &applied_version);  // remove me
-
   bool should_send_op(
     pg_shard_t peer,
     const hobject_t &hoid) override {