From: Kefu Chai <kchai@redhat.com>
Date: Sat, 10 Apr 2021 14:37:02 +0000 (+0800)
Subject: pybind/mgr/selftest: use enum to define Workload
X-Git-Tag: v17.1.0~2225^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c371c2405a6389b80d2d8ebdc41294600afa975f;p=ceph.git

pybind/mgr/selftest: use enum to define Workload

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/pybind/mgr/selftest/module.py b/src/pybind/mgr/selftest/module.py
index b70d9c3876a..7458bbde711 100644
--- a/src/pybind/mgr/selftest/module.py
+++ b/src/pybind/mgr/selftest/module.py
@@ -1,6 +1,6 @@
 
 from mgr_module import MgrModule, CommandResult, CLICommand, Option
-import errno
+import enum
 import json
 import random
 import sys
@@ -8,6 +8,14 @@ import threading
 from typing import List, Optional, Tuple
 
 
+# These workloads are things that can be requested to run inside the
+# serve() function
+class Workload(enum.Enum):
+    COMMAND_SPAM = 'command_spam'
+    THROW_EXCEPTION = 'throw_exception'
+    SHUTDOWN = 'shutdown'
+
+
 class Module(MgrModule):
     """
     This module is for testing the ceph-mgr python interface from within
@@ -19,14 +27,6 @@ class Module(MgrModule):
     activities in its serve() thread.
     """
 
-    # These workloads are things that can be requested to run inside the
-    # serve() function
-    WORKLOAD_COMMAND_SPAM = "command_spam"
-    WORKLOAD_THROW_EXCEPTION = "throw_exception"
-    SHUTDOWN = "shutdown"
-
-    WORKLOADS = (WORKLOAD_COMMAND_SPAM, WORKLOAD_THROW_EXCEPTION)
-
     # The test code in qa/ relies on these options existing -- they
     # are of course not really used for anything in the module
     MODULE_OPTIONS = [
@@ -80,7 +80,7 @@ class Module(MgrModule):
         return 0, '', 'Self-test succeeded'
 
     @CLICommand('mgr self-test background start')
-    def backgroun_start(self, workload: str) -> Tuple[int, str, str]:
+    def backgroun_start(self, workload: Workload) -> Tuple[int, str, str]:
         '''
         Activate a background workload (one of command_spam, throw_exception)
         '''
@@ -444,7 +444,7 @@ class Module(MgrModule):
         assert False, repr(what)
 
     def shutdown(self):
-        self._workload = self.SHUTDOWN
+        self._workload = Workload.SHUTDOWN
         self._event.set()
 
     def _command_spam(self):
@@ -471,12 +471,12 @@ class Module(MgrModule):
 
     def serve(self):
         while True:
-            if self._workload == self.WORKLOAD_COMMAND_SPAM:
+            if self._workload == Workload.COMMAND_SPAM:
                 self._command_spam()
-            elif self._workload == self.SHUTDOWN:
+            elif self._workload == Workload.SHUTDOWN:
                 self.log.info("Shutting down...")
                 break
-            elif self._workload == self.WORKLOAD_THROW_EXCEPTION:
+            elif self._workload == Workload.THROW_EXCEPTION:
                 raise RuntimeError("Synthetic exception in serve")
             else:
                 self.log.info("Waiting for workload request...")