From: John Mulligan <jmulligan@redhat.com>
Date: Mon, 9 Mar 2026 23:04:41 +0000 (-0400)
Subject: mgr/cephadm: remove check for manages_own_next_action
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c3d4bf632a29e601e95ff9127ce01736ab566e1c;p=ceph.git

mgr/cephadm: remove check for manages_own_next_action

Now all service classes will use a choose_next_action method that
they've customized or one inherited from the base class.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
---

diff --git a/src/pybind/mgr/cephadm/serve.py b/src/pybind/mgr/cephadm/serve.py
index a3af2ad10dbd..c98321e8111b 100644
--- a/src/pybind/mgr/cephadm/serve.py
+++ b/src/pybind/mgr/cephadm/serve.py
@@ -1173,7 +1173,7 @@ class CephadmServe:
                     f'{dd.name()} daemon entrypoint args {dd.extra_entrypoint_args} -> {spec.extra_entrypoint_args}')
                 dd.extra_entrypoint_args = spec.extra_entrypoint_args
                 action = 'redeploy'
-            elif svc_obj.manages_own_next_action:
+            else:
                 # method uses new action enum type
                 _scheduled_action = utils.Action.create(scheduled_action)
                 _action = svc_obj.choose_next_action(
@@ -1197,10 +1197,6 @@ class CephadmServe:
                     )
                     # convert back to legacy str type
                     action = str(_action)
-            elif last_deps != deps:
-                sym_diff = set(deps).symmetric_difference(last_deps)
-                self.log.info(f'Reconfiguring {dd.name()} deps {last_deps} -> {deps} (diff {sym_diff})')
-                action = 'reconfig'
             action = _ceph_service_next_action(
                 action, dd.daemon_type, dd.name(), self.mgr, last_config
             )