From: Sage Weil <sage@redhat.com>
Date: Thu, 11 Feb 2016 13:51:25 +0000 (-0500)
Subject: unittest_compression_[*_][plugin]: fix warnings
X-Git-Tag: v10.1.0~389^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c63325850dba240f12e28ff73f6ee633d4b8a4ec;p=ceph.git

unittest_compression_[*_][plugin]: fix warnings

test/compressor/test_compression_plugin.cc: In function ‘int main(int, char**)’:
test/compressor/test_compression_plugin.cc:55:38: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result]
   system("mkdir -p .libs/compressor");
                                      ^
test/compressor/test_compression_plugin.cc:56:59: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result]
   system("cp .libs/libceph_example.so* .libs/compressor/");
                                                           ^

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/test/compressor/test_compression_plugin.cc b/src/test/compressor/test_compression_plugin.cc
index 6d8153259f17..e898b8023338 100644
--- a/src/test/compressor/test_compression_plugin.cc
+++ b/src/test/compressor/test_compression_plugin.cc
@@ -52,8 +52,10 @@ int main(int argc, char **argv) {
   global_init(NULL, args, CEPH_ENTITY_TYPE_CLIENT, CODE_ENVIRONMENT_UTILITY, 0);
   common_init_finish(g_ceph_context);
 
-  system("mkdir -p .libs/compressor");
-  system("cp .libs/libceph_example.so* .libs/compressor/");
+  int r = system("mkdir -p .libs/compressor");
+  (void)r;
+  r = system("cp .libs/libceph_example.so* .libs/compressor/");
+  (void)r;
   g_conf->set_val("plugin_dir", ".libs", false, false);
 
   ::testing::InitGoogleTest(&argc, argv);
diff --git a/src/test/compressor/test_compression_plugin_snappy.cc b/src/test/compressor/test_compression_plugin_snappy.cc
index 495e641e09e6..2855f7adf44f 100644
--- a/src/test/compressor/test_compression_plugin_snappy.cc
+++ b/src/test/compressor/test_compression_plugin_snappy.cc
@@ -38,8 +38,10 @@ int main(int argc, char **argv) {
   global_init(NULL, args, CEPH_ENTITY_TYPE_CLIENT, CODE_ENVIRONMENT_UTILITY, 0);
   common_init_finish(g_ceph_context);
 
-  system("mkdir -p .libs/compressor");
-  system("cp .libs/libceph_snappy.so* .libs/compressor/");
+  int r = system("mkdir -p .libs/compressor");
+  (void)r;
+  r = system("cp .libs/libceph_snappy.so* .libs/compressor/");
+  (void)r;
 
   g_conf->set_val("plugin_dir", ".libs", false, false);
 
diff --git a/src/test/compressor/test_compression_plugin_zlib.cc b/src/test/compressor/test_compression_plugin_zlib.cc
index 6cf108547cc7..0e956a1317b1 100644
--- a/src/test/compressor/test_compression_plugin_zlib.cc
+++ b/src/test/compressor/test_compression_plugin_zlib.cc
@@ -37,8 +37,10 @@ int main(int argc, char **argv) {
   global_init(NULL, args, CEPH_ENTITY_TYPE_CLIENT, CODE_ENVIRONMENT_UTILITY, 0);
   common_init_finish(g_ceph_context);
 
-  system("mkdir -p .libs/compressor");
-  system("cp .libs/libceph_zlib.so* .libs/compressor/");
+  int r = system("mkdir -p .libs/compressor");
+  (void)r;
+  r = system("cp .libs/libceph_zlib.so* .libs/compressor/");
+  (void)r;
 
   g_conf->set_val("plugin_dir", ".libs", false, false);
 
diff --git a/src/test/compressor/test_compression_zlib.cc b/src/test/compressor/test_compression_zlib.cc
index aba2f442f545..d6f6985c0f13 100644
--- a/src/test/compressor/test_compression_zlib.cc
+++ b/src/test/compressor/test_compression_zlib.cc
@@ -27,7 +27,7 @@ TEST(CompressionZlib, compress_decompress)
 {
   CompressionZlib sp;
   EXPECT_EQ(sp.get_method_name(), "zlib");
-  char* test = "This is test text";
+  const char* test = "This is test text";
   int len = strlen(test);
   bufferlist in, out;
   in.append(test, len);
@@ -43,7 +43,7 @@ TEST(CompressionZlib, compress_decompress_chunk)
 {
   CompressionZlib sp;
   EXPECT_EQ(sp.get_method_name(), "zlib");
-  char* test = "This is test text";
+  const char* test = "This is test text";
   buffer::ptr test2 ("1234567890", 10);
   int len = strlen(test);
   bufferlist in, out;