From: Dave Chinner Date: Fri, 15 Mar 2013 12:28:09 +0000 (+0000) Subject: xfstests: use _notrun for tape checks X-Git-Tag: v2022.05.01~3470 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=c74db9e225d12737f57630653459db20164c9f12;p=xfstests-dev.git xfstests: use _notrun for tape checks _require_tape is failing tests when no TAPE_DEV is specified. It should be using _notrun for these cases rather than trying to open code the $seqres.notrun magic file manipulations. Signed-off-by: Dave Chinner Reviewed-by: Phil White Signed-off-by: Rich Johnston --- diff --git a/common/dump b/common/dump index 3df61912..5d4d2aea 100644 --- a/common/dump +++ b/common/dump @@ -139,9 +139,7 @@ _check_onl() echo "ERROR: mt -f $dumptape failed" cat $tmp.status - echo "mt -f $dumptape failed" >$seq.notrun - status=$NOTRUNSTS - exit + _notrun "mt -f $dumptape failed" fi @@ -151,9 +149,7 @@ _check_onl() echo "ERROR: $dumptape is not online" cat $tmp.status - echo "dumptape, $dumptape, is not online" >$seq.notrun - status=$NOTRUNSTS - exit + _notrun "dumptape, $dumptape, is not online" fi } @@ -229,10 +225,7 @@ _require_tape() dumptape=$1 if [ -z "$dumptape" -o "@" == "$dumptape" ]; then - echo "This test requires a dump tape - none was specified" - echo "No dump tape specified" >$seqres.notrun - status=$NOTRUNSTS - exit + _notrun "No dump tape specified" fi _check_onl