From: Sage Weil <sage@newdream.net>
Date: Fri, 12 Dec 2008 23:02:55 +0000 (-0800)
Subject: osd: simplify peer code a bit
X-Git-Tag: v0.6~78
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c7c33923e588ff9c0795779e14d7a593324e9e00;p=ceph.git

osd: simplify peer code a bit

Combine the two loops.
---

diff --git a/src/osd/PG.cc b/src/osd/PG.cc
index cbcd403e04b1..3b78e1de04a5 100644
--- a/src/osd/PG.cc
+++ b/src/osd/PG.cc
@@ -1090,9 +1090,14 @@ void PG::peer(ObjectStore::Transaction& t,
   */  
 
   // gather missing from peers
+  bool have_all_missing = true;
   for (unsigned i=1; i<acting.size(); i++) {
     int peer = acting[i];
     if (peer_info[peer].is_empty()) continue;
+    if (peer_missing.count(peer) == 0) {
+      dout(10) << " still need log+missing from osd" << peer << dendl;
+      have_all_missing = false;
+    }
     if (peer_log_requested.count(peer) ||
         peer_summary_requested.count(peer)) continue;
 
@@ -1101,18 +1106,8 @@ void PG::peer(ObjectStore::Transaction& t,
     query_map[peer][info.pgid] = Query(Query::FULLLOG, info.history);
     peer_log_requested.insert(peer);
   }
-
-  // did we get them all?
-  bool have_missing = true;
-  for (unsigned i=1; i<acting.size(); i++) {
-    int peer = acting[i];
-    if (peer_info[peer].is_empty()) continue;
-    if (peer_missing.count(peer)) continue;
-    
-    dout(10) << " waiting for log+missing from osd" << peer << dendl;
-    have_missing = false;
-  }
-  if (!have_missing) return;
+  if (!have_all_missing)
+    return;
 
   dout(10) << " peers_complete_thru " << peers_complete_thru << dendl;