From: Jos Collin <jcollin@redhat.com>
Date: Wed, 26 Apr 2017 02:40:41 +0000 (+0530)
Subject: test: fixing assert that creates warning: comparison between signed and unsigned... 
X-Git-Tag: v12.0.3~194^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=c931002f6b66b2d61e1dfb56940877c4b57aeb7e;p=ceph.git

test: fixing assert that creates warning: comparison between signed and unsigned integer expressions

This fixes the additional comments in the PR: https://github.com/ceph/ceph/pull/14705
Fixed the review comments too.

Signed-off-by: Jos Collin <jcollin@redhat.com>
---

diff --git a/src/test/simple_spin.cc b/src/test/simple_spin.cc
index 6857a51ef366..04b4fc07e5f6 100644
--- a/src/test/simple_spin.cc
+++ b/src/test/simple_spin.cc
@@ -33,21 +33,19 @@ TEST(SimpleSpin, Test1)
   pthread_t thread1;
   pthread_t thread2;
   ret = pthread_create(&thread1, NULL, mythread, NULL);
-  ASSERT_EQ(ret, 0);
+  ASSERT_EQ(0, ret);
   ret = pthread_create(&thread2, NULL, mythread, NULL);
-  ASSERT_EQ(ret, 0);
+  ASSERT_EQ(0, ret);
   ret = pthread_join(thread1, NULL);
-  ASSERT_EQ(ret, 0);
+  ASSERT_EQ(0, ret);
   ret = pthread_join(thread2, NULL);
-  ASSERT_EQ(ret, 0);
-  ASSERT_EQ(counter, n);
+  ASSERT_EQ(0, ret);
+  ASSERT_EQ(n, counter);
 
 
   // Should also work with pass-by-reference:
   // (Note that we don't care about cross-threading here as-such.)
   counter = 0;
-  uint32_t urhs = 0;
-  ASSERT_EQ(counter, urhs);
   async(std::launch::async, []() {
         for(int i = 0; n != i; ++i) {
             simple_spin_lock(lock);
@@ -55,6 +53,6 @@ TEST(SimpleSpin, Test1)
             simple_spin_unlock(lock);
         }
        });
-  ASSERT_EQ(counter, n);
+  ASSERT_EQ(n, counter);
 }