From: Kefu Chai <kchai@redhat.com>
Date: Sat, 8 May 2021 08:34:03 +0000 (+0800)
Subject: osd/PG: do not check for empty before loop
X-Git-Tag: v17.1.0~1981^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=ca259ece92136f8c96bcd9686ec1ffe6e517818d;p=ceph-ci.git

osd/PG: do not check for empty before loop

simpler this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/osd/PG.cc b/src/osd/PG.cc
index 23edfaeaf1d..82c2bf2bf8f 100644
--- a/src/osd/PG.cc
+++ b/src/osd/PG.cc
@@ -2668,15 +2668,13 @@ std::pair<ghobject_t, bool> PG::do_delete_work(
       max,
       &olist,
       &next);
-    if (!olist.empty()) {
-      for (auto& oid : olist) {
-        if (oid == pgmeta_oid) {
-          dout(20) << __func__ << " removing pgmeta object " << oid << dendl;
-        } else {
-          dout(0) << __func__ << " additional unexpected onode"
-                  <<" new onode has appeared since PG removal started"
-                  << oid << dendl;
-        }
+    for (auto& oid : olist) {
+      if (oid == pgmeta_oid) {
+        dout(20) << __func__ << " removing pgmeta object " << oid << dendl;
+      } else {
+        dout(0) << __func__ << " additional unexpected onode"
+                <<" new onode has appeared since PG removal started"
+                << oid << dendl;
       }
     }
   }