From: amitkuma <amitkuma@redhat.com>
Date: Wed, 2 Aug 2017 17:03:33 +0000 (+0530)
Subject: mds: Added NULL check before dereference
X-Git-Tag: v12.1.3~76^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ca8ea9d77d74e847ac4af47bf4fc03ab2a15f933;p=ceph.git

mds: Added NULL check before dereference

Fixed:
** 1405280 Explicit null dereferenced
CID 1405280 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
20. var_deref_model: Passing null pointer diri to check_access, which dereferences it.

Signed-off-by: Amit Kumar amitkuma@redhat.com
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index cf32c95f6864..58702558b5b9 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -3095,9 +3095,11 @@ void Server::handle_client_lookup_ino(MDRequestRef& mdr,
     if (!mds->locker->acquire_locks(mdr, rdlocks, wrlocks, xlocks))
       return;
 
-    // need read access to directory inode
-    if (!check_access(mdr, diri, MAY_READ))
-      return;
+    if (diri != NULL) {
+      // need read access to directory inode
+      if (!check_access(mdr, diri, MAY_READ))
+        return;
+    }
   }
 
   if (want_parent) {