From: Zack Cerza <zack@redhat.com>
Date: Thu, 11 Jul 2024 16:06:25 +0000 (-0600)
Subject: Run.report_outcome: Drop fake_ctx
X-Git-Tag: 1.2.0~17^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=cb0815cf272b48c5b234b681a15bfbbd034a672c;p=teuthology.git

Run.report_outcome: Drop fake_ctx

Signed-off-by: Zack Cerza <zack@redhat.com>
---

diff --git a/teuthology/run.py b/teuthology/run.py
index 8ac6b7b5..e465b6a3 100644
--- a/teuthology/run.py
+++ b/teuthology/run.py
@@ -260,7 +260,7 @@ def get_initial_tasks(lock, config, machine_type):
     return init_tasks
 
 
-def report_outcome(config, archive, summary, fake_ctx):
+def report_outcome(config, archive, summary):
     """ Reports on the final outcome of the command. """
     status = get_status(summary)
     passed = status == 'pass'
@@ -406,4 +406,4 @@ def main(args):
         run_tasks(tasks=config['tasks'], ctx=fake_ctx)
     finally:
         # print to stdout the results and possibly send an email on any errors
-        report_outcome(config, archive, fake_ctx.summary, fake_ctx)
+        report_outcome(config, archive, fake_ctx.summary)
diff --git a/teuthology/test/test_run.py b/teuthology/test/test_run.py
index c176c8f6..c2bcff4a 100644
--- a/teuthology/test/test_run.py
+++ b/teuthology/test/test_run.py
@@ -1,7 +1,7 @@
 import pytest
 import docopt
 
-from unittest.mock import patch, call, Mock
+from unittest.mock import patch, call
 
 from teuthology import run
 from scripts import run as scripts_run
@@ -133,13 +133,12 @@ class TestRun(object):
     @patch("sys.exit")
     def test_report_outcome(self, m_sys_exit, m_open, m_email_results, m_try_push_job_info, m_safe_dump, m_get_status):
         m_get_status.return_value = "fail"
-        fake_ctx = Mock()
         summary = {"failure_reason": "reasons"}
         summary_dump = "failure_reason: reasons\n"
         config = {"email-on-error": True}
         config_dump = "email-on-error: true\n"
         m_safe_dump.side_effect = [None, summary_dump, config_dump]
-        run.report_outcome(config, "the/archive/path", summary, fake_ctx)
+        run.report_outcome(config, "the/archive/path", summary)
         m_try_push_job_info.assert_called_with(config, summary)
         m_open.assert_called_with("the/archive/path/summary.yaml", "w")
         assert m_email_results.called