From: Radoslaw Zarzynski Date: Thu, 11 Dec 2025 18:28:25 +0000 (+0100) Subject: Revert "PrimeryLogPG: don't accept ops with mixed balance_reads and rwordered flags" X-Git-Tag: testing/wip-pdonnell-testing-20260219.182737-tentacle~6^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=cbed99dcc30f16ce00127fc48b91dc7a8419792f;p=ceph-ci.git Revert "PrimeryLogPG: don't accept ops with mixed balance_reads and rwordered flags" This reverts commit 4b01c004b5dc342cbdfb7cb26b47f6afe6245599 as there are clients-in-production that actually issue writes marked as balanced- or localized-reads. Preserving backward compatibility here is way more important than anything else. Fixes: https://tracker.ceph.com/issues/73997 Signed-off-by: Radoslaw Zarzynski (please note: this revert is not a cherry-pick from main) --- diff --git a/src/osd/PrimaryLogPG.cc b/src/osd/PrimaryLogPG.cc index 9ef012eb930..710b07f058c 100644 --- a/src/osd/PrimaryLogPG.cc +++ b/src/osd/PrimaryLogPG.cc @@ -2045,15 +2045,6 @@ void PrimaryLogPG::do_op(OpRequestRef& op) } } - // check for op with rwordered and rebalance or localize reads - if ((m->has_flag(CEPH_OSD_FLAG_BALANCE_READS) || m->has_flag(CEPH_OSD_FLAG_LOCALIZE_READS)) && - op->rwordered()) { - dout(4) << __func__ << ": rebelance or localized reads with rwordered not allowed " - << *m << dendl; - osd->reply_op_error(op, -EINVAL); - return; - } - if ((m->get_flags() & (CEPH_OSD_FLAG_BALANCE_READS | CEPH_OSD_FLAG_LOCALIZE_READS)) && op->may_read() &&