From: Sage Weil <sage@redhat.com>
Date: Tue, 31 Jul 2018 13:31:23 +0000 (-0500)
Subject: mgr/devicehealth: fix style for returns
X-Git-Tag: v14.0.1~723^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ccdfcc7e726c08e07458327ff412eb878486611b;p=ceph.git

mgr/devicehealth: fix style for returns

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/pybind/mgr/devicehealth/module.py b/src/pybind/mgr/devicehealth/module.py
index ad809822548..2503489543e 100644
--- a/src/pybind/mgr/devicehealth/module.py
+++ b/src/pybind/mgr/devicehealth/module.py
@@ -211,7 +211,7 @@ class Module(MgrModule):
                 data = self.extract_smart_features(raw_data)
                 self.put_device_metrics(ioctx, device, data)
         ioctx.close()
-        return (0, "", "")
+        return 0, "", ""
 
     def scrape_all(self):
         osdmap = self.get("osd_map")
@@ -232,7 +232,7 @@ class Module(MgrModule):
                 self.put_device_metrics(ioctx, device, data)
 
         ioctx.close()
-        return (0, "", "")
+        return 0, "", ""
 
     def scrape_device(self, devid):
         r = self.get("device " + devid)
@@ -251,7 +251,7 @@ class Module(MgrModule):
                 data = self.extract_smart_features(raw_data)
                 self.put_device_metrics(ioctx, device, data)
         ioctx.close()
-        return (0, "", "")
+        return 0, "", ""
 
     def do_scrape_osd(self, osd_id, ioctx, devid=''):
         self.log.debug('do_scrape_osd osd.%d' % osd_id)
@@ -322,7 +322,7 @@ class Module(MgrModule):
                     res[key] = v
             except:
                 pass
-        return (0, json.dumps(res, indent=4), '')
+        return 0, json.dumps(res, indent=4), ''
 
     def check_health(self):
         self.log.info('Check health')
@@ -427,7 +427,7 @@ class Module(MgrModule):
                     'detail': ls,
                 }
         self.set_health_checks(checks)
-        return (0,"","")
+        return 0, "", ""
 
     def is_osd_in(self, osdmap, osd_id):
         for osd in osdmap['osds']: