From: John Mulligan Date: Mon, 10 Oct 2022 14:21:02 +0000 (-0400) Subject: install-deps: switch to C.UTF-8 locale X-Git-Tag: v18.1.0~1001^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=cd1cd1bd3350c85aee8f496f63522422dcad73de;p=ceph.git install-deps: switch to C.UTF-8 locale The en_US.UTF-8 locale is not always going to present on all systems. Specifically, setting en_US.UTF-8 causes numerous warnings when running this script on a CentOS Stream 8 container. Rather than install additional packages to suppress the warning, use the C.UTF-8 locale. Additionally, try to update the comment explaining the line to something based on the commit history rather than the confusing term "vulnerable". Signed-off-by: John Mulligan --- diff --git a/install-deps.sh b/install-deps.sh index 0703143d6cf2..3762b3de0356 100755 --- a/install-deps.sh +++ b/install-deps.sh @@ -18,7 +18,9 @@ mkdir -p $DIR if test $(id -u) != 0 ; then SUDO=sudo fi -export LC_ALL=en_US.UTF-8 # the following is vulnerable to i18n +# enable UTF-8 encoding for programs like pip that expect to +# print more than just ascii chars +export LC_ALL=C.UTF-8 ARCH=$(uname -m)