From: Samuel Just <sjust@redhat.com>
Date: Tue, 15 Apr 2025 22:56:09 +0000 (-0700)
Subject: crimson: remove unused OperationThrottler::with_throttle
X-Git-Tag: v20.3.0~42^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=cd9dcf6582ca23ac25abba1813b2bebe79b29142;p=ceph.git

crimson: remove unused OperationThrottler::with_throttle

It's now unused, and these combinator style wrappers are easy to
misuse and hard to read compared with RAII and coroutines.

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/osd/osd_operation.h b/src/crimson/osd/osd_operation.h
index cee9bf2974f6..167ceac463f3 100644
--- a/src/crimson/osd/osd_operation.h
+++ b/src/crimson/osd/osd_operation.h
@@ -334,17 +334,6 @@ public:
     });
   }
 
-  template <typename F>
-  auto with_throttle(
-    crimson::osd::scheduler::params_t params,
-    F &&f) {
-    return acquire_throttle(params)
-      .then(std::forward<F>(f))
-      .finally([this] {
-	release_throttle();
-      });
-  }
-
 private:
   void dump_detail(Formatter *f) const final;
 
diff --git a/src/crimson/osd/shard_services.h b/src/crimson/osd/shard_services.h
index df9ecc1c35fc..61880909bcdd 100644
--- a/src/crimson/osd/shard_services.h
+++ b/src/crimson/osd/shard_services.h
@@ -593,7 +593,6 @@ public:
   }
 
   FORWARD_TO_OSD_SINGLETON(get_pool_info)
-  FORWARD(with_throttle, with_throttle, local_state.throttler)
   FORWARD(get_throttle, get_throttle, local_state.throttler)
 
   FORWARD_TO_OSD_SINGLETON(build_incremental_map_msg)