From: Ronen Friedman Date: Wed, 25 Jun 2025 14:25:08 +0000 (-0500) Subject: osd/scrub: some perf counters priority was '0' X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=cf1864a61061bc9de05eedd987f64307bcf7c501;p=ceph.git osd/scrub: some perf counters priority was '0' Some scrub perf counters were created without specifying individual priorities, assuming by mistake that the default priority is '_INTERESTING'. That was not the case, and those perf counters were not reported. Fixes: https://tracker.ceph.com/issues/71842 Signed-off-by: Ronen Friedman --- diff --git a/src/osd/osd_perf_counters.cc b/src/osd/osd_perf_counters.cc index 6efc9d5c5e957..7959765f90c70 100644 --- a/src/osd/osd_perf_counters.cc +++ b/src/osd/osd_perf_counters.cc @@ -335,6 +335,9 @@ PerfCounters *build_osd_logger(CephContext *cct) { osd_plb.add_u64_counter( l_osd_pg_biginfo, "osd_pg_biginfo", "PG updated its biginfo attr"); + // back to "interesting" counters + osd_plb.set_prio_default(PerfCountersBuilder::PRIO_INTERESTING); + /// scrub's replicas reservation time/#replicas histogram PerfHistogramCommon::axis_config_d rsrv_hist_x_axis_config{ "number of replicas", @@ -448,7 +451,7 @@ PerfCounters *build_osd_logger(CephContext *cct) { l_osd_scrub_ec_failed_elapsed, "failed_scrubs_ec_elapsed", "time to scrub failure ec"); - // the replica reservation process - EC + // the secondaries reservation process - EC osd_plb.add_u64_counter( l_osd_scrub_ec_reserv_success, "scrub_ec_reservations_completed", "successfully completed reservation processes EC");