From: Maysam Yabandeh Date: Tue, 23 Jul 2019 03:01:25 +0000 (-0700) Subject: Disable refresh snapshot feature by default (#5606) X-Git-Tag: v6.2.4~3 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=cfd6eb3e689c5a7e8a663e1311bd8981bdff3425;p=rocksdb.git Disable refresh snapshot feature by default (#5606) Summary: There are concerns about the correctness of this patch. Disabling by default until the concerns are resolved. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5606 Differential Revision: D16428064 Pulled By: maysamyabandeh fbshipit-source-id: a89280f0ea85796c9c9dfbfd9a8e91dad9b000b3 --- diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h index a1071f62..1f370deb 100644 --- a/include/rocksdb/options.h +++ b/include/rocksdb/options.h @@ -275,10 +275,10 @@ struct ColumnFamilyOptions : public AdvancedColumnFamilyOptions { // this option helps reducing the cpu usage of long-running compactions. The // feature is disabled when max_subcompactions is greater than one. // - // Default: 0.1s + // Default: 0 // // Dynamically changeable through SetOptions() API - uint64_t snap_refresh_nanos = 100 * 1000 * 1000; // 0.1s + uint64_t snap_refresh_nanos = 0; // Disable automatic compactions. Manual compactions can still // be issued on this column family