From: Avan Thakkar <athakkar@redhat.com>
Date: Tue, 20 Sep 2022 20:30:31 +0000 (+0530)
Subject: exporter: avoid stoi for empty pid_str
X-Git-Tag: v18.1.0~429^2~18^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=cff3cf1d31342be759cdd848cd074a247b56b238;p=ceph-ci.git

exporter: avoid stoi for empty pid_str

Fixes: https://tracker.ceph.com/issues/57619
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
---

diff --git a/src/exporter/DaemonMetricCollector.cc b/src/exporter/DaemonMetricCollector.cc
index 8d5bad0d97b..a8fef46548e 100644
--- a/src/exporter/DaemonMetricCollector.cc
+++ b/src/exporter/DaemonMetricCollector.cc
@@ -129,7 +129,9 @@ void DaemonMetricCollector::dump_asok_metrics() {
       dout(1) << "pid path is empty; process metrics won't be fetched for: "
               << daemon_name << dendl;
     }
-    daemon_pids.push_back({daemon_name, std::stoi(pid_str)});
+    if (!pid_str.empty()) {
+      daemon_pids.push_back({daemon_name, std::stoi(pid_str)});
+    }
     json_object dump = boost::json::parse(perf_dump_response).as_object();
     json_object schema = boost::json::parse(perf_schema_response).as_object();
     for (auto &perf : schema) {