From: Josh Durgin <josh.durgin@inktank.com>
Date: Mon, 3 Mar 2014 17:03:29 +0000 (-0800)
Subject: Revert "librbd: remove limit on number of objects in the cache"
X-Git-Tag: v0.78~103
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d00a92724c88972ed2a25aee64d72077a6d092d4;p=ceph.git

Revert "librbd: remove limit on number of objects in the cache"

Disabling this limit causes too much memory usage in some
workloads.

This reverts commit 0559d31db29ea83bdb6cec72b830d16b44e3cd35.
---

diff --git a/src/librbd/ImageCtx.cc b/src/librbd/ImageCtx.cc
index decddf485be3..6477e8dfd048 100644
--- a/src/librbd/ImageCtx.cc
+++ b/src/librbd/ImageCtx.cc
@@ -87,7 +87,7 @@ namespace librbd {
       object_cacher = new ObjectCacher(cct, pname, *writeback_handler, cache_lock,
 				       NULL, NULL,
 				       cct->_conf->rbd_cache_size,
-				       (uint64_t) -1, // unlimited number of objects
+				       10,  /* reset this in init */
 				       init_max_dirty,
 				       cct->_conf->rbd_cache_target_dirty,
 				       cct->_conf->rbd_cache_max_dirty_age,
@@ -183,6 +183,14 @@ namespace librbd {
       snprintf(format_string, len, "%s.%%016llx", object_prefix.c_str());
     }
 
+    // size object cache appropriately
+    if (object_cacher) {
+      uint64_t obj = cct->_conf->rbd_cache_size / (1ull << order);
+      ldout(cct, 10) << " cache bytes " << cct->_conf->rbd_cache_size << " order " << (int)order
+		     << " -> about " << obj << " objects" << dendl;
+      object_cacher->set_max_objects(obj * 4 + 10);
+    }
+
     ldout(cct, 10) << "init_layout stripe_unit " << stripe_unit
 		   << " stripe_count " << stripe_count
 		   << " object_size " << layout.fl_object_size