From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Wed, 13 Feb 2013 16:50:32 +0000 (+0100)
Subject: mds/CDir.cc: use !empty() instead of size()
X-Git-Tag: v0.58~66^2~24
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d0896404a9a5acd5430aff62d4684dc5ccb00ea6;p=ceph.git

mds/CDir.cc: use !empty() instead of size()

Use empty() since it should be prefered as it has, following the
standard, a constant time complexity regardless of the containter
type. The same is not guaranteed for size().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/mds/CDir.cc b/src/mds/CDir.cc
index 22cdf48b5af0..a1ed05cea263 100644
--- a/src/mds/CDir.cc
+++ b/src/mds/CDir.cc
@@ -1175,7 +1175,7 @@ void CDir::add_waiter(uint64_t tag, Context *c)
 /* NOTE: this checks dentry waiters too */
 void CDir::take_waiting(uint64_t mask, list<Context*>& ls)
 {
-  if ((mask & WAIT_DENTRY) && waiting_on_dentry.size()) {
+  if ((mask & WAIT_DENTRY) && !waiting_on_dentry.empty()) {
     // take all dentry waiters
     while (!waiting_on_dentry.empty()) {
       map<string_snap_t, list<Context*> >::iterator p = waiting_on_dentry.begin();