From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Tue, 5 Nov 2013 18:51:14 +0000 (+0100)
Subject: ErasureCodeExample.h: prefer prefix ++operator for non-primitive types
X-Git-Tag: v0.74~90^2~1^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d0cf2bfb3206d90123b448732bd243ce73631d0c;p=ceph.git

ErasureCodeExample.h: prefer prefix ++operator for non-primitive types

Prefer prefix ++operator for non-primitive types like iterators for
performance reasons. Prefix ++/-- operators avoid creating a temporary
copy.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/osd/ErasureCodeExample.h b/src/test/osd/ErasureCodeExample.h
index 0fd55187559f..07694ea409aa 100644
--- a/src/test/osd/ErasureCodeExample.h
+++ b/src/test/osd/ErasureCodeExample.h
@@ -76,7 +76,7 @@ public:
     set <int> available_chunks;
     for (map<int, int>::const_iterator i = c2c.begin();
 	 i != c2c.end();
-	 i++)
+	 ++i)
       available_chunks.insert(i->first);
     return minimum_to_decode(want_to_read, available_chunks, minimum);
   }
@@ -109,7 +109,7 @@ public:
     const bufferptr ptr = out.buffers().front();
     for (set<int>::iterator j = want_to_encode.begin();
          j != want_to_encode.end();
-         j++) {
+         ++j) {
       bufferptr chunk(ptr, (*j) * chunk_length, chunk_length);
       (*encoded)[*j].push_front(chunk);
     }
@@ -125,7 +125,7 @@ public:
     unsigned chunk_length = (*chunks.begin()).second.length();
     for (set<int>::iterator i = want_to_read.begin();
          i != want_to_read.end();
-         i++) {
+         ++i) {
       if (chunks.find(*i) != chunks.end()) {
 	//
 	// If the chunk is available, just copy the bufferptr pointer
@@ -146,7 +146,7 @@ public:
         bufferptr chunk(chunk_length);
         map<int, bufferlist>::const_iterator k = chunks.begin();
         const char *a = k->second.buffers().front().c_str();
-        k++;
+        ++k;
         const char *b = k->second.buffers().front().c_str();
         for (unsigned j = 0; j < chunk_length; j++) {
           chunk[j] = a[j] ^ b[j];