From: Yehuda Sadeh <yehuda@inktank.com>
Date: Thu, 27 Sep 2012 19:44:33 +0000 (-0700)
Subject: rgw: fix resource leak
X-Git-Tag: v0.54~83^2~16
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d2159bf0b72b14c92323f44dd13ea30eec1e6f11;p=ceph.git

rgw: fix resource leak

coverity bug 728055

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
---

diff --git a/src/rgw/rgw_rest_s3.cc b/src/rgw/rgw_rest_s3.cc
index 512c8cf6b54c..f211997fc0e8 100644
--- a/src/rgw/rgw_rest_s3.cc
+++ b/src/rgw/rgw_rest_s3.cc
@@ -622,17 +622,17 @@ void RGWDeleteMultiObj_ObjStore_S3::send_partial_response(pair<string,int>& resu
       s->formatter->dump_string("Key", result.first);
       s->formatter->close_section();
     } else if (result.first < 0) {
-      struct rgw_html_errors *r = new rgw_html_errors;
+      struct rgw_html_errors r;
       int err_no;
 
       s->formatter->open_object_section("Error");
 
       err_no = -(result.second);
-      rgw_get_errno_s3(r, err_no);
+      rgw_get_errno_s3(&r, err_no);
 
       s->formatter->dump_string("Key", result.first);
-      s->formatter->dump_int("Code", r->http_ret);
-      s->formatter->dump_string("Message", r->s3_code);
+      s->formatter->dump_int("Code", r.http_ret);
+      s->formatter->dump_string("Message", r.s3_code);
       s->formatter->close_section();
     }